PowerShell foreach file in folder using a lot of memory -

-

i'm new powershell , programming, i'm sure code can optimized more.

however, biggest problem code puts it's data foreach loop in memory. best way prevent this?

i started rewriting script script found here: powershell: delete files older x days

edit: oh, there 60 000~ files in each targetfolder way.

## set window title $title = $host.ui.rawui.windowtitle $titdef = $title $host.ui.rawui.windowtitle = "checking files. not close " + "($title)"  ## debug (0=nothing, 1=extended log, 2=extended log+screen) $debug = "2"  ## log file $log = "c:\status\status.txt" add-content $log "nul"  ## clear log before adding new data  remove-item $log  ## folders check $targetfolder1 = “\\server\c$\biztalkprojects\udc\output\ume” $targetfolder2 = “\\server\c$\biztalkprojects\udc\output\upp”  ## required stuff $now = get-date $days = “2” $twodays = $now.adddays(-$days) $folder1 = get-childitem $targetfolder1 -include * $folder2 = get-childitem $targetfolder2 -include *  ## window message "checking files newer $days days in:" "$targetfolder1" "$targetfolder2" "" "this may take 5-15 minutes . . . (will commit 250mb~ ram during period)"  ## reset variable $ok "0" $ok = 0  if ($debug -eq "2") {"check1"} foreach ($file in $folder1) {     $filelastwrite = $file.lastwritetime     if ($file.lastwritetime -le $twodays) {         $ok = $ok + "0"         if ($debug -eq "2") {             "ok + 0 (=$ok) $file ($filelastwrite)"             }     } else {         $ok = $ok + "1"         if ($debug -eq "2") {             "ok + 1 (=$ok) $file ($filelastwrite)"              }     } } if ($debug -eq "2") {"check2"} foreach ($file in $folder2) {     $filelastwrite = $file.lastwritetime     if ($file.lastwritetime -le $twodays) {         $ok = $ok + "0"         if ($debug -eq "2") {             "ok + 0 (=$ok) $file ($filelastwrite)"             }     } else {         $ok = $ok + "1"         if ($debug -eq "2") {             "ok + 1 (=$ok) $file ($filelastwrite)"              }     } } if ($ok -gt "0") {     if ($debug -eq "2") {         ""         "found $ok file(s) newer $days days"         }     add-content $log "ok"     if ($debug -ge "1") {         add-content $log "found $ok file(s) newer $days days"         }     }     else {         if ($debug -eq "2") {         ""         "found $ok file(s) newer $days days"         }     add-content $log "error"     if ($debug -ge "1") {         add-content $log "found $ok file(s) newer $days days"         }     } $host.ui.rawui.windowtitle = $titdef

this version works. helped! 

## set window title $title = $host.ui.rawui.windowtitle $titdef = $title $host.ui.rawui.windowtitle = "checking files. not close " + "($title)"  ## debug (0=nothing, 1=extended log, 2=extended log+screen) $debug = "2"  ## log file $log = "c:\status\status.txt" add-content $log "nul"  ## clear log before adding new data  remove-item $log  ## folders check $targetfolder1 = “\\server\c$\biztalkprojects\udc\output\ume” $targetfolder2 = “\\server\c$\biztalkprojects\udc\output\upp”  ## required stuff $now = get-date $days = “2” $twodays = $now.adddays(-$days)  ## window message "checking files newer $days days in:" "$targetfolder1" "$targetfolder2" "" "this may take 5-15 minutes . . ."  ## reset variable $ok "0" $ok = 0  get-childitem $targetfolder1,$targetfolder2 -filter *.xml |where-object {     $filelastwrite = $_.lastwritetime     if ($filelastwrite -le $twodays) {         $ok = $ok + "0"     } else {         $ok = $ok + "1"     } } if ($ok -gt "0") {     if ($debug -eq "2") {         ""         "found $ok file(s) newer $days days"         }     add-content $log "ok"     if ($debug -ge "1") {         add-content $log "found $ok file(s) newer $days days"         }     }     else {         if ($debug -eq "2") {         ""         "found $ok file(s) newer $days days"         }     add-content $log "error"     if ($debug -ge "1") {         add-content $log "found $ok file(s) newer $days days"         }     } $host.ui.rawui.windowtitle = $titdef

try:

 $folder1 = get-childitem $targetfolder1 -filter *.xml

much more performant using include (on large set of files). or better:

 get-childitem $targetfolder1 -filter *.xml | % {}

edit

i see now, problems due include! if need use wildcards , nor regular expressions child item, use filter instead. more performant because not use regular expression matching.

try:

 $folder1 = get-childitem $targetfolder1 -filter *

even if it's not clear filtering there (or want include)...everything? may don't need wildcard @ all.

in humble opinion, best way prevent foreach loop in memory piping. however, due nature of script (many nested controls inside loop) it's not easy.

try with:

 $folder1 | % {   # ... }

even if doubt improve performances.

or:

 get-childitem $targetfolder1 -include * | % {   # ... }

Comments

Post a Comment

Popular posts from this blog

Cursor error with postgresql, pgpool and php -

-
hey, struggling bit determine exact cause of error has been popping in our release environment. there not seem dealing particular error on google. this error message getting: sqlstate[34000]: invalid cursor name: 7 error: portal "" not exist the error pops when using pdo prepared statements. this setup our release environment: pgpool 3.0.1 (the postgresql backend in streaming replication mode!) php 5.3.5 postgresql 9.0 edit: architecture 64bit. the same error not manifest in our test environment (edit: forgot mention, standard test environment uses postgresql 9.0 without pgpool). thus, led suspect pgpool @ least partly suspect. does know probable causes error are? edit: ok, here example of kind of code causes error. $sql = 'select * '; $sql .= 'from "mytable" "mystuff" '; $sql .= 'where "mytable"."status" = 1 '; $sql .= 'and "mytable"."mytableid" = :table...
Read more

delphi - ESC/P programming! -

-
why need use because printers using tprinter prints weird hieroglyph @ beginning of printable area. my problem if send commands, nothing happens. esc e (#27 #69) - sending escape sequence didn't work expected. removed first letter , rest of string made bold. eg. hello -> ello . after changed esc e esc (#27 #69 #27), worked fine. example managed figure out, but... trying select character table "esc t n" (#27 #116 n), make "õäöü" work. command doesn't work. nothing happens! , command supported esc/p, esc/p 2 , 9-pin esc/p, should work fine. manual can found here . if has ever needed use esc/p commands maybe 1 can shed light how work them! thanks in advance! edit: in previous post asked more or less same question though answers how did send commands printer. (i'll change question there according answers!) i accepted ken's answer, because claimed way transferred commands wasn't best , got work escape command. problem after t...
Read more

c++ - error: use of deleted function -

-
i've been working on c++ code friend has written , following error have never seen before when compiling gcc4.6: error: use of deleted function ‘gamefsm_<std::array<c, 2ul> >::hdealt::hdealt()’ implicitly deleted because default definition ill-formed: uninitialized non-static const member ‘const h_t floppokergamefsm_<std::array<c, 2ul> >::hdealt::h’ edit: comes part of code using boost msm: boost webpage edit2: there no = delete() used anywhere in sourcecode. generally speaking, error mean? should looking when type of error occurs? i don't think other answers mentioning =deleted; syntax correct. error message says default constructor has been deleted implicitly . says why: class contains non-static, const variable, not initialized default ctor. class x { const int x; }; since x::x const , must initialized -- default ctor wouldn't initialize (because it's pod type). therefore, default ctor, need define 1 (and must ...
Read more